powa-team / powa-archivist

powa-archivist: the powa PostgreSQL extension
http://powa.readthedocs.io/
PostgreSQL License
51 stars 20 forks source link

New release needed with PG10 support #11

Closed df7cb closed 6 years ago

df7cb commented 6 years ago

powa-archivist needs updating for PostgreSQL 10:

00:00:26.036 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -g -O2 -fdebug-prefix-map=/build/postgresql-10-b8KUP6/postgresql-10-10~beta4=. -fstack-protector-strong -Wformat -Werror=format-security -fno-omit-frame-pointer -fPIC -I. -I./ -I/usr/include/postgresql/10/server -I/usr/include/postgresql/internal  -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/mit-krb5  -c -o powa.o powa.c
00:00:26.282 powa.c: In function '_PG_init':
00:00:26.282 powa.c:150:9: error: 'BackgroundWorker {aka struct BackgroundWorker}' has no member named 'bgw_main'; did you mean 'bgw_name'?
00:00:26.282   worker.bgw_main = powa_main;
00:00:26.282          ^~~~~~~~
00:00:26.282          bgw_name
00:00:26.284 powa.c: In function 'powa_main':
00:00:26.284 powa.c:277:4: error: too few arguments to function 'WaitLatch'
00:00:26.284     WaitLatch(&MyProc->procLatch,
00:00:26.284     ^~~~~~~~~
00:00:26.284 In file included from powa.c:17:0:
00:00:26.284 /usr/include/postgresql/10/server/storage/latch.h:174:12: note: declared here
00:00:26.284  extern int WaitLatch(volatile Latch *latch, int wakeEvents, long timeout,
00:00:26.284             ^~~~~~~~~
rjuju commented 6 years ago

Hello @ChristophBerg

Actually this has already been handled (see https://github.com/dalibo/powa-archivist/commit/e130b526bc9b7b1f2fc6b5223f46d831eb97ba5c and https://github.com/dalibo/powa-archivist/commit/3fc71eb7a785c855c8929f410b4c19079fd81f8b), however this hasn't been released yet.

Given yesterdays' bug report (see https://github.com/dalibo/powa-archivist/issues/10), I prefer to work on proper fix and testing before releasing a new version.

BTW, is there anything special I should do WRT debian packaging?

df7cb commented 6 years ago

Oh sorry, I didn't realize there's a separate devel branch. I'll update the title to make this a request for a new release instead.

Re Debian, it's probably best to keep the debian/ directory in the "debian" branch. I can update the packaging once there's a tarball, that should finally be a use-case for the push rights you gave me a while ago... :)

rjuju commented 6 years ago

Hello @ChristophBerg, I just pushed the fix for #10 and a last update for the changelog. Current head (7583bb1505442c7f4d95a1c7b198aaeea907419f) should be v3.1.1. Should I push the tag now or wait for you to push anything needed for the packaging? It's finally time to use your commit bit :)

df7cb commented 6 years ago

Will have a look now :)

df7cb commented 6 years ago

Everything looking good :)

rjuju commented 6 years ago

Thanks a lot! I just pushed the REL_3_1_1 tag on current head (0bccb29911ab9c62fb5c5032ebfe9332a90e72f1). If it needs to be on previous commit tell me, I'll update it, otherwide I'll make the github release. In the meantime I'll make the pgxn release since it won't include the debian directory anyway.

df7cb commented 6 years ago

The tag is perfect, thanks!