powa-team / powa-archivist

powa-archivist: the powa PostgreSQL extension
http://powa.readthedocs.io/
PostgreSQL License
51 stars 20 forks source link

Cleanup old databases after the expiration period #19

Closed marco44 closed 5 years ago

marco44 commented 5 years ago

We keep the dropped databases, the purpose being to still be able to access them when they have been dropped. But still, we have to cleanup after a while. The statements and other collected objects are already cleaned up after powa.retention. Now we also cleanup the statements from these databases from powa_statements and powa_qualstats_quals.

marco44 commented 5 years ago

@frost242 and @rdunklau you are asked for a review because I also change a bit the way we insert data from your extensions: records associated to a dbid aren't removed from shared memory when the associated database is dropped, so I had to add a filter to the associated _snapshot functions.

marco44 commented 5 years ago

As you feel. @rdunklau is quite busy right now :)

rjuju commented 5 years ago

I just (squashed) and merged the PR!

rjuju commented 5 years ago

I just realized that we forgot to update the changelog, I just pushed an additional commit for that.