search

powa-team / powa-archivist

powa-archivist: the powa PostgreSQL extension
http://powa.readthedocs.io/
PostgreSQL License
53 stars 20 forks source link

typo in powa--4.0.0.sql in REL_4_0_0 #30

Closed pessonnier closed 4 years ago

pessonnier commented 4 years ago

in REL_4_0_0, the file powa--4.0.0.sql has a typo : two missing 's' line 584 and 585

    res.seq_can_per_sec = (a.seq_scan - b.seq_scan)::double precision / sec;
    res.idx_can_per_sec = (a.idx_scan - b.idx_scan)::double precision / sec;

should be

    res.seq_scan_per_sec = (a.seq_scan - b.seq_scan)::double precision / sec;
    res.idx_scan_per_sec = (a.idx_scan - b.idx_scan)::double precision / sec;
rjuju commented 4 years ago

Thanks @pessonnier I'll take care of that soon!

rjuju commented 4 years ago

This should be fixed as of https://github.com/powa-team/powa-archivist/commit/37a09c69a137f2f1d658132f0795c5e2ba306ce8. Can you confirm that it solves all your issues? If yes I'll release this version shortly.

pessonnier commented 4 years ago

it's look fine, no errors during create extension nor in powa-web

                                     List of installed extensions
        Name        | Version |   Schema   |                        Description                        
--------------------+---------+------------+-----------------------------------------------------------
 btree_gist         | 1.5     | public     | support for indexing common datatypes in GiST
 hypopg             | 1.1.3   | public     | Hypothetical indexes for PostgreSQL
 pg_qualstats       | 2.0.1   | public     | An extension collecting statistics about quals
 pg_stat_kcache     | 2.1.1   | public     | Kernel statistics gathering
 pg_stat_statements | 1.6     | public     | track execution statistics of all SQL statements executed
 pg_wait_sampling   | 1.1     | public     | sampling based statistics of wait events
 plpgsql            | 1.0     | pg_catalog | PL/pgSQL procedural language
 powa               | 4.0.1   | public     | PostgreSQL Workload Analyser-core
(8 rows)

thank you

rjuju commented 4 years ago

FTR v4.0.1 was released a few days ago.