powa-team / powa-archivist

powa-archivist: the powa PostgreSQL extension
http://powa.readthedocs.io/
PostgreSQL License
53 stars 20 forks source link

Add the toplevel column in powa_statements #55

Closed marco44 closed 1 year ago

marco44 commented 1 year ago

...so that we don't have those duplicates inside our history

rjuju commented 1 year ago

Running the regression tests locally leads to multiple errors. I went ahead and added some basic CI to run the regression tests on all currently supported major versions to make sure this is detected earlier.

rjuju commented 1 year ago

Thanks for the PR, merged!

Note that you can't add a column in the middle of a table in a version that we can upgrade to, as otherwise we could break things for people relying on the column order depending on whether they install from scratch or upgrade to that version. And while changing that I realized that we actually relied on the column order in a few queries, so this would have been broken in case of an upgrade.

I fixed all of that in f6ec254e0177e013985288f377ebabe3dabf6f9f.