search

powa-team / powa-archivist

powa-archivist: the powa PostgreSQL extension
http://powa.readthedocs.io/
PostgreSQL License
52 stars 20 forks source link

Wrong copy/paste? #9

Closed sttachoires closed 7 years ago

sttachoires commented 7 years ago

Hi, I've noticed a compilation problem with powa.c, at line 71 Seems to be an incorrect " pg_attribute_noreturn()" here.

rjuju commented 7 years ago

Oops,

It's a macro defined in postgres source code, but it's only for pg 9.5+ (see commit https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=bbfd7eda).

So it appears you're using pg 9.4, you should consider upgrading :)

Thanks for reporting, I'll fix!

rjuju commented 7 years ago

Commit https://github.com/dalibo/powa-archivist/commit/8d9878f4597726f29cd23b2ce1158297004fc02e should the issue, thanks a lot for reporting it!