search

powa-team / powa-web

PoWA user interface
http://powa.readthedocs.io/
73 stars 31 forks source link

wizard: effectively merge nodes with same qualid #163

Closed pgiraud closed 1 year ago

pgiraud commented 1 year ago

Previous change 291a34d2ecbd67d4e40e1055b873f6f3b9ba8325 was not doing anything actually.

rjuju commented 1 year ago

Hi,

That's quite strange, I'm sure I tested the mentioned commit as I had a usecase that was previously broken and fixed with it. I'm not really around my computer today unfortunately, so I will double check that tomorrow.

rjuju commented 1 year ago

Well, I'm not sure how I ended up with this buggy commit but you're right it was definitely broken so I'm merging this one.

Thanks a lot!

rjuju commented 1 year ago

Just for the sake of archive history (I should have put that in the original commit), this part is for merging the same qual on different queries, for instance:

SELECT * FROM some_table WHERE id = 1;
SELECT count(*) FROM some_table WHERE id = 1;

and have the wizard know that this single qual is related to both queries, and triies to validate the possible index for each.