search

powa-team / powa-web

PoWA user interface
http://powa.readthedocs.io/
73 stars 31 forks source link

fixup! Remove sqlalchemy dependency. #166

Closed pgiraud closed 1 year ago

pgiraud commented 1 year ago

I added a fixup commit for the removal of SQLAlchemy dependency.

rjuju commented 1 year ago

Ah thanks, I was sure I tested this code path. Should I merge this PR / rebase / push force or do you want to put this patch at the begining of your big PR? Getting rid of sqlalchemy wasn't a particularly simple commit so I wouldn't be surprised if you found more similar problems.

pgiraud commented 1 year ago

Let's add it directly to the v5 branch. Can you do the merge, then fixup and push force?

rjuju commented 1 year ago

Sure!

rjuju commented 1 year ago

It should be ok now, thanks for the fix!