powa-team / powa-web

PoWA user interface
http://powa.readthedocs.io/
73 stars 31 forks source link

Multiple config changes in a single tooltip #181

Closed pgiraud closed 7 months ago

pgiraud commented 7 months ago

Fix for https://github.com/powa-team/powa-web/pull/165#issuecomment-1813729935

pgiraud commented 7 months ago

Screenshot from 2023-11-16 11-16-49

rjuju commented 7 months ago

On Thu, 16 Nov 2023, 18:15 Pierre GIRAUD, @.***> wrote:

Fix for #165 (comment) https://github.com/powa-team/powa-web/pull/165#issuecomment-1813729935

You can view, comment on, or merge this pull request online at:

https://github.com/powa-team/powa-web/pull/181 Commit Summary

Just a quick note on that commit. For now powa-web is entirely self contained, in the sense that it won't open any external connection, except of course the remote servers in some pages (which can entirely be opt out). I think that a lot of people expect this behaviour and wouldn't be happy with such a change. I think that at least pgadmin faced quite some backlash recently with something similar for instance. Could you instead add the underlying file(s) locally?

Message ID: @.***>

pirlgon commented 7 months ago

In your second commit, you can specify that only the first five changes are displayed.

pgiraud commented 7 months ago

@rjuju I just pushed new commits. The font is now loaded locally.

Also I made some adjustments on the styling. And fixed bugs caught by @pirlgon (list with the first item with no name).

pgiraud commented 7 months ago

Here's the new styling which I hope is easier to read. Screenshot from 2023-11-17 12-00-58

rjuju commented 7 months ago

@pgiraud (and @pirlgon) thanks a lot! It looks quite better than before, I'm verry happy with this change.

I did some other work in the same branch in the meantime, do you plan to rebase the branch or should I cherry-pick the commits?

pgiraud commented 7 months ago

Rebased.

pgiraud commented 7 months ago

I force pushed new commits but I don't see them here. Last commit should be 8bb862f.

rjuju commented 7 months ago

Thanks a lot! The latest commit is now visible on the UI so it should be ok to merge :)