search

powa-team / powa-web

PoWA user interface
http://powa.readthedocs.io/
73 stars 31 forks source link

Make sure toprow headers count match columns for grid #189

Closed pgiraud closed 11 months ago

pgiraud commented 11 months ago

Previously we were expecting the first column not to be provided and to be taken into account in the UI. We now explicitely set it server side.

rjuju commented 11 months ago

I'm fine with that change. Looking at the Grid.vue template, I'm wondering if the merge attribute is actually still needed?

I see that it was used in the previous js code (powa/static/scss/powa_backgrid.scss) to add some custom css class (https://github.com/powa-team/powa-web/blob/master/powa/static/scss/powa_backgrid.scss#L92-L94) but I don't see anything like that wit the new UI.

pgiraud commented 11 months ago

I'm fine with that change. Looking at the Grid.vue template, I'm wondering if the merge attribute is actually still needed?

I see that it was used in the previous js code (powa/static/scss/powa_backgrid.scss) to add some custom css class (https://github.com/powa-team/powa-web/blob/master/powa/static/scss/powa_backgrid.scss#L92-L94) but I don't see anything like that wit the new UI.

Agreed. It's the right time to remove it. See second commit.

rjuju commented 11 months ago

Great, thanks a lot as always, merged!