powa-team / powa-web

PoWA user interface
http://powa.readthedocs.io/
73 stars 30 forks source link

Reapply search filter when new data is received #67

Closed pgiraud closed 5 years ago

pgiraud commented 5 years ago

Fixes #66

rjuju commented 5 years ago

actually I don't understand the original issue. @marco44 (or @pgiraud if you got it) could you provide more details on what's the problem is, and how to trigger it?

What I tested is to enter some text on /database/overview page, then change the date filter. What's happening then (in master) is that the query list is filtered accordingly, but the graphs are not. Maybe I also hit some cache problem in my browser.

pgiraud commented 5 years ago

Here's the steps to reproduce the issue (on master):

On master, after the date range is changed, even though the search field still displays the text previously entered by user, the data in the grid is not filtered anymore.

With the current PR, the search filter is applied once new data is received.

But you were right to mention browser caching issue. Because what I forgot is to compile javascript. I'm running powa in debug mode.

PR update to come.

rjuju commented 5 years ago

Perfect! Thanks a lot and sorry for the delay.