Limit max version of sqlalchemy and tornado

powa-team / powa-web

PoWA user interface

http://powa.readthedocs.io/

73 stars 30 forks source link

Limit max version of sqlalchemy and tornado #73

Closed mchubby closed 2 years ago

mchubby commented 5 years ago

Graphs won't render in SQLAlchemy 1.3.x
WSGIAdapter has been deprecated in tornado 5.1 and removed in 6.0. See related message at https://groups.google.com/forum/#!topic/python-tornado/9VUOZc8SIC0

This is a stopgap measure and the incompatibilities should probably be addressed in the codebase. It may have consequences on ascendant compatibility, however.

The documentation website should also be updated at https://github.com/powa-team/powa/blob/master/docs/powa-web/index.rst

rjuju commented 5 years ago

Ouch, thanks a lot for warning!

Do you know what should be used instead of WSGIAdapter on tornado 5.1+ by any chance?

I'll look at the breakage on SQLAlchemy 1.3+ soon.

rjuju commented 5 years ago

The issue with SQLAlchemy 1.3 should be fixed now in master. Can you confirm if that's also ok for you?

mchubby commented 2 years ago

No longer relevant, so closing.