search

powder-rb / powder

Makes Pow even easier. I mean really, really, ridiculously easy
http://git.io/powder
MIT License
1.29k stars 69 forks source link

Extended get_gist to follow (at most one) redirects #94

Closed styrmis closed 10 years ago

styrmis commented 10 years ago

References Issue https://github.com/rodreegez/powder/issues/93

thomasklemm commented 10 years ago

Thanks. Looks good to me. Second opinions?

styrmis commented 10 years ago

One thing I've been wondering is if it wouldn't perhaps be better to just store the initialiser code directly in the repo and avoid accessing gists at all as that would prevent released versions from breaking when GitHub makes changes.

On 1 Feb 2014, at 05:04, Thomas Klemm notifications@github.com wrote:

Thanks. Looks good to me. Second opinions?

\ Reply to this email directly or view it on GitHub.

thomasklemm commented 10 years ago

Actually I rather favor updating the Github gist urls every now and then when they change (how often can they? ;) ) than making the get_gist method more complex. The current redirection might not last forever on the Github side. I've updated all urls in #96.

Thanks again reports that a redirect is taking place and efforts in putting this PR together, Stefan.