Fix #31 - Update twitter status to change in karma

powderblock / DealWithItReddit

Reddit bot. Computer vision for facial detection and transformation. Python, PRAW, & OpenCV.

http://www.reddit.com/user/DealWithItbot/

MIT License

33 stars 3 forks source link

Fix #31 - Update twitter status to change in karma #37

Closed porglezomp closed 9 years ago

porglezomp commented 9 years ago

Move twitter status updating into the main loop
Remove checking for an increase in karma before updating status
Add karma_yesterday() to parse karma.txt and determine the amount of karma gained during the previous day
Moved reddit comment string into a variable called message_template
Reformatted a few lines for line length
Change already_done to a set instead of a list for performance

Requesting a code review and test

powderblock commented 9 years ago

I have been testing this. I would like very verbose testing due the issues we've been facing lately. Everything so far looks good and is working.

Going to test this for at least two hours for the new karma stuff.

powderblock commented 9 years ago

So far, so good.

Twitter desc is updating properly.

porglezomp commented 9 years ago

We should change the message to have "karma" after "{karma}"

On Jan 18, 2015, at 1:16 PM, Blade Nelson notifications@github.com wrote:

So far, so good.

Twitter desc is updating properly.

— Reply to this email directly or view it on GitHub.

powderblock commented 9 years ago

I think that's enough testing? Everything works great. Just add karma after {karma} when updating Twitter description.

Ready to merge when you add that.

porglezomp commented 9 years ago

Okay, it's ready to be merged then.