Open qwang98 opened 1 month ago
Ready for review again.
Implement all comments. Ready for a final review.
Changes:
Tested using: cargo run -r --bin powdr-rs compile riscv/tests/riscv_data/keccak -o output && RUST_BACKTRACE=full cargo test --release --package powdr-riscv --test riscv -- keccak --exact --show-output --ignored
All comments addressed and ready for review again. @pacheco
Split roadblocked contents to #1408. This PR is ready for a final review. @leonardoalt
Input for syscall is one memory pointer to the state array of 25 gl fe. Output is calculated in place.
All functions outside of keccakf are executed in Rust. Might need to delete everything except keccakf from keccakf.asm (including the padding, updating, and byte <-> u64 conversions).
Not tested. Should I wait till all infrastructure needed are merged? Technically can also do the following for the machine and I think I can test it already?