powdr-labs / powdr

A modular stack for zkVMs, with a focus on productivity, security and performance.
Apache License 2.0
416 stars 82 forks source link

Make all `SourceRef` equal #2103

Closed Schaeff closed 4 days ago

Schaeff commented 1 week ago

When comparing pil expressions, the source information gets in the way. Experiment with ignoring it when comparing. This respects the requirements here

chriseth commented 6 days ago

Looks good, I'm just wondering if we would assume them not be equal at some point. Can't think of a situation though.

Could you maybe document that in SourceRef and maybe also in Expression?