search

powellb / seapy

State Estimation and Analysis in Python
MIT License
28 stars 21 forks source link

Minor warning fixes #43

Closed dalepartridge closed 7 years ago

dalepartridge commented 7 years ago

Fix warnings that occur when detiding: 1) remove mask from tidal fit before removing from zeta 2) Only perform fit on valid data

powellb commented 7 years ago

This change won't work if you don't have a masked array. If you want to do what you have, you have to cast the data into a masked array at the top of the function.

dalepartridge commented 7 years ago

The fit is being performed on a masked array because zeta is defined to be one, so out['fit’] is also masked (albeit with just a global False value) which was what was causing the warning

On Jun 30, 2017, at 4:36 PM, Brian Powell notifications@github.com wrote:

This change won't work if you don't have a masked array. If you want to do what you have, you have to cast the data into a masked array at the top of the function.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/powellb/seapy/pull/43#issuecomment-312405485, or mute the thread https://github.com/notifications/unsubscribe-auth/AMaBMfqLWURJY3Mbp-S2Z9FkMDvanAuWks5sJbCSgaJpZM4OLL4U.