search

powellb / seapy

State Estimation and Analysis in Python
MIT License
28 stars 21 forks source link

Import of setup duplicated in setup.py #61

Closed hadfieldnz closed 4 years ago

hadfieldnz commented 5 years ago

In setup.py on the master branch at lines 6 & 7, the setup function is imported twice.

from setuptools import find_packages, setup
from numpy.distutils.core import setup

The effect of the second import is to replace the first. This gives the correct behaviour (as numpy.distutils.core is the one required) but is potentially confusing. I recommend

from setuptools import find_packages
from numpy.distutils.core import setup

Priority is low as there is no change in function. I have not prepared a PR.

powellb commented 5 years ago

Thanks, I'll fix when I merge in the latest updates from the development branch.

powellb commented 4 years ago

Sorry for the delay. This has been fixed and new version is tagged as 0.5.0.

hadfieldnz commented 4 years ago

Thanks.

Mark Hadfield 51 Volga St Wellington 6023, NZ

On Thu, 14 Nov 2019 at 20:47, Brian Powell notifications@github.com wrote:

Sorry for the delay. This has been fixed and new version is tagged as 0.5.0.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/powellb/seapy/issues/61?email_source=notifications&email_token=AHCXKHX5XGWJL55EWQVYZ5TQTT7A7A5CNFSM4I7F6YP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEA5E7A#issuecomment-553767548, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHCXKHTUFIE4WMCFCVXDIIDQTT7A7ANCNFSM4I7F6YPQ .