search

powellb / seapy

State Estimation and Analysis in Python
MIT License
28 stars 21 forks source link

tide_error #9

Closed dalepartridge closed 8 years ago

dalepartridge commented 8 years ago

Tide_error function, date2day and day2date accept arrays and lists, get_time fixed properly.

powellb commented 8 years ago

Still no go...

1) tide_error doesn't belong in tide. tide_error is only relevant for ROMS (it uses ROMS history and tide forcing files). As per my earlier message, it goes in roms.analysis. But, as noted below, we have more than just this, so I have created a new module: roms.tides. I put tide_error in there, and it (along with obsgen.add_ssh_tide) use the new forcing loader. You have old forcing files because the seapy generated ones create tidal_constituents (not tides). I have just checked in a function to load a tidal forcing file.

2) You need to remove import seapy from lib.py