search

powellnathanj / mcollective-yum-agent

http://nathanpowell.org
17 stars 11 forks source link

Deprecate downloadonly in favour of --downloadonly #9

Open robinbowes opened 8 years ago

robinbowes commented 8 years ago

Working on the basis that mco yum command... should, as near as is possible, function the same as yum command... I suggest removing the downloadonly command in favour of using the --downloadonly switch.

powellnathanj commented 8 years ago

It is --downloadonly because that is how you have to use it when calling yum directly. Even in 7, where the plugin is no longer required the man page shows the two dashes.

Does that change your mind?

robinbowes commented 8 years ago

Er, I'm not sure what point you're making.

I'm suggesting using --downloadonly and removing the downloadonly command from the mcollective plugin.

powellnathanj commented 8 years ago

Derp. I read it backwards. I didn't remember how was actually implemented. In that case, yes I agree wholeheartedly 👍

astanford commented 7 years ago

I'm not able to get --downloadonly working any more. I'm sure it's a syntax issue on my part; could you give an example of the proper syntax?

This seems incorrect:

mco yum update --downloadonly -F hostname=cmgdtcpasntap1

robinbowes commented 7 years ago

That syntax works for me.

astanford commented 7 years ago

Interesting! For me, that actually patched the server (--downloadonly was ignored). @robinbowes your server wasn't patched, correct?

robinbowes commented 7 years ago

Hmm, you're right - my servers were all patched :)

I guess that needs some work...

astanford commented 7 years ago

I'd guess that it works if it's called correctly. @slaney you alive out there?

robinbowes commented 7 years ago

Looks like the generate_args function [1] needs to handle downloadonly

[1] https://github.com/slaney/mcollective-yum-agent/blob/master/agent/yum.rb#L103

powellnathanj commented 7 years ago

I am here, I am watching. I am trying to get some time to dedicate to the task.

On Fri, Oct 28, 2016 at 11:56 AM, Robin Bowes notifications@github.com wrote:

Looks like the generate_args function [1] needs to handle downloadonly

[1] https://github.com/slaney/mcollective-yum-agent/blob/ master/agent/yum.rb#L103

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/slaney/mcollective-yum-agent/issues/9#issuecomment-256958477, or mute the thread https://github.com/notifications/unsubscribe-auth/AAATlBIxknQSkkYh9aj1GQmVtulciYxtks5q4hsygaJpZM4JwgFT .

Nathan Powell