Embed value capturing helper into transpiled code - Githubissues

power-assert-js / babel-plugin-espower

Babel plugin for power-assert

MIT License

93 stars 6 forks source link

Embed value capturing helper into transpiled code #11

Closed twada closed 8 years ago

twada commented 8 years ago

Embed value capturing helper (_capt and _expr) into instrumented code.

This PR brings some advantages.

enhanced assertion doesn't need to have _capt and _expr methods
allow destructuring of assertion methods (need to update patterns though)
remove capturing logic from new empower-core
solves possible async problem
reduce dependencies since espower dependency is eliminated

TODO

[x] implement embedded helper
[x] eliminate espower dependency
[x] seeking for the way of importing helper, not embedding (like babel-runtime) => punted
[x] refactor
[x] document