Unknown node type Super.

power-assert-js / babel-plugin-espower

Babel plugin for power-assert

MIT License

93 stars 6 forks source link

Unknown node type Super. #2

Closed mysticatea closed 9 years ago

mysticatea commented 9 years ago

Hello!

I got an error Unknown node type Super.. Maybe, an issue about combination of CallExpression and Super?

// test.js
class Hoge extends Object {
  constructor() {
    super();
  }
}

$ babel test.js --plugins babel-plugin-espower

C:\~~\node_modules\babel-core\lib\babel\helpers\parse.js:70
    throw err;
          ^
Error: test.js: Unknown node type Super.
    at Controller.traverse (C:\~~\node_modules\babel-plugin-espower\node_modules\escallmatch\node_modules\estraverse\estraverse.js:513:31)
    at Object.traverse (C:\~~\node_modules\babel-plugin-espower\node_modules\escallmatch\node_modules\estraverse\estraverse.js:705:27)
    at isSameAstDepth (C:\~~\node_modules\babel-plugin-espower\node_modules\escallmatch\index.js:110:16)
...

Versions:

babel: 5.1.11
babel-core: 5.1.11
babel-plugin-espower: 0.2.1

Thanks!

mysticatea commented 9 years ago

Hm, this issue seems to be in estraverse.

Super on ESTree. - https://github.com/estree/estree/blob/e5b93db15b429aba0cb1b823fc3352b4496e6996/es6.md#expressions
Super on Esprima - https://github.com/jquery/esprima/blob/deef03ca006b03912d9f74b041f9239a9045181f/esprima.js#L164
Super on Babel - https://github.com/babel/babel/blob/c9518bb60d45d741ecab5dcc354f432005bfe69b/src/babel/types/alias-keys.json#L73
SuperExpression on estraverse - https://github.com/estools/estraverse/blob/166ebbe0a8d45ceb2391b6f5ef5d1bab6bfb267a/estraverse.js#L199

EDIT:

ESLint - https://github.com/eslint/eslint/blob/628d9a843bf4b96e1077f058073b7215e9f169ec/lib/eslint.js#L27-29

Oh....

azu commented 9 years ago

twada commented 9 years ago

I saw Change Super interface by azu · Pull Request #48 · estools/estraverse lands. Now looking for a new release of estraverse. Thank you so much @azu !!

azu commented 9 years ago

estraverse 4.0.0 has been released.

twada commented 9 years ago

@azu :tada: Okay I'll take the major bump in.

twada commented 9 years ago

@mysticatea Sorry for my late response. I've just released v0.2.2, so please check it out.

mysticatea commented 9 years ago

Yay, thank you @twada, @azu!
I got the fix!

twada commented 9 years ago

@mysticatea Thank you for reporting!