power-media / prado3

Automatically exported from code.google.com/p/prado3
Other
0 stars 0 forks source link

No https support from wsdl generator [with solution] #472

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
If a prado powered webservice's wsdl is called using https protocol, the 
generated wsdl still points to http protocol rendering the webservice unusable 
through secure connection.

This is due to hardcoded 'http://' string in 3rdParty/Wsdl.php's constructor.
Line 93 :
if ($serviceUri == '') $serviceUri = 
'http://'.$_SERVER['HTTP_HOST'].$_SERVER['PHP_SELF'];

should become

$protocol=(isset($_SERVER['HTTPS']) && 
($_SERVER['HTTPS']!=='off'))?'https://':'http://';
if ($serviceUri == '') $serviceUri = 
$protocol.$_SERVER['HTTP_HOST'].$_SERVER['PHP_SELF'];

Original issue reported on code.google.com by piotrows...@gmail.com on 16 Aug 2013 at 1:04

GoogleCodeExporter commented 8 years ago
Additionally the following check on line 93
 if ($serviceUri == '')
can be safely replaced with
if ($serviceUri === '')

Original comment by piotrows...@gmail.com on 16 Aug 2013 at 1:06

GoogleCodeExporter commented 8 years ago
applied as r3313, thank you

Original comment by ctrlal...@gmail.com on 20 Aug 2013 at 9:39