Do we make those two changes with the comments that I made before merging or do I just approve since it is minor?
We will make the two changes or discuss them. But either way a decision needs to be made before merging. General best practice is if you have comments in your PR. You address everything before merging unless otherwise.
For example, at work I had 2 PRs open and both required 1 more coworker to sign off on. We dont have restrictions on the branch so I could merge when ever. But it is best to have everyone look at it. So I messaged him asked him when he gets a chance to review it, and he just told me to merge it in if I had 3 approvers.
We will make the two changes or discuss them. But either way a decision needs to be made before merging. General best practice is if you have comments in your PR. You address everything before merging unless otherwise.
For example, at work I had 2 PRs open and both required 1 more coworker to sign off on. We dont have restrictions on the branch so I could merge when ever. But it is best to have everyone look at it. So I messaged him asked him when he gets a chance to review it, and he just told me to merge it in if I had 3 approvers.