Closed PierreRustOrange closed 2 years ago
hum, there has been a full reformat on storage_socket.c
in commit 256b54eb694f968d30733a07fc337a68ced77fae , and I now have conflicts all over the file, that's quite painful to merge :(
Is there a recommended / required formatting tool, in order to avoid such issue ?
By the way, the new formatting style of this file is now different from the style in all other files... Is that expected ? For example:
{
and }
are not a their own line, Sorry, I fixed a warning treated as an error (two declaration on a same line) and it seams that my auto-format did some nasty things... They were no significative change so you can force your commits. For future commits, compilation warning are treated as error by the CI. We are using a lsp to detect those errors before hand.
ok, I've pushed a merge where I force the previous formatting style.
I'm afraid I have reintroduced the two declarations on the same line, I'll push a fix for that but I don't see the CI complaining, where can I find that ?
Still, it would be a good thing to agree on a common tool for formatting, I'm clearly not sure my formatting is consistent either ...
This PR is meant to fix #11 and is still a work in progress and should not be merged yet !
The basic mechanism works but there are some missing things: