search

powercord-community / suggestions

Repo where you can find and share plugin suggestions for Powercord
27 stars 4 forks source link

MPRIS2 controller (like the Spotify one) + RPC client to share what I am listening to. #138

Open NyaomiDEV opened 4 years ago

NyaomiDEV commented 4 years ago

Description

In simple words, a plugin for *nix users that lets them control their players with the "same" powercord controls for Spotify, plus an RPC service which displays what users listen to in their statuses.

More info

The plugin connects to DBus and from there it retrieves the media player list. It checks for playing media, and then it displays it on the Rich Presence. In the meantime, it also enables Powercord's media controls (this is for lazy people who don't want to open their media player when chatting I guess).

There's a MPRIS2 library out there I wrote specifically for this matter, it's here

MulverineX commented 3 years ago

@AryToNeX ^^ I'm trying to consolidate all of the media player suggestions, especially since they all will now need to depend on a relatively common addition to powercord core in the security refactor of V3. Perhaps you could close this?

MulverineX commented 3 years ago

Woops didn't realize this was a library, updated the Media API post ^^. Should be good now.

NyaomiDEV commented 3 years ago

@MulverineX

First off, MPRIS2 is not a library. It is an interface specification, or to be as general as possible, it can be also described (loosely) as a protocol. The "library" is some software that implements that protocol. I guess you made this assumption based upon those words of mine:

There's a MPRIS2 library out there I wrote specifically for this matter

This doesn't imply anything about it being a library. I was just specifying that I wrote one that can use the MPRIS2 protocol to achieve the result I was looking for.

Then, you are not considering the "RPC" part of my suggestion, like, at all. I specifically suggested the title, artist and album and track duration fields to be displayed via Discord's Rich Presence (this can be done by registering an "app" on Discord's developer centre and then using some token to update it, fairly trivial stuff). Your suggestion, however, doesn't mention any of that.

Just as I read from your feature request, you want a fancy media player widget (and that's legit) but none other than that. You're just "justifying" your request by saying "let's make a media API out of it" when it could also be enormously unnecessary.

As V3's documentation is not out, we can't know for sure if any of this is doable. We can't know if it'll be superfluous to make an entire abstraction just for one or two Powercord plugins; and I hope for a plugin to be made with your requests, as an entire Powercord-provided Media API is wasted time on this matter.

MulverineX commented 3 years ago

@AryToNeX bowser has made it very clear what is happening in v3. Plugins will have no direct native access, everything will have to go through core. It is not "wasted time" because the scope is very similar in size, and Powercord is open-source; whichever developer(s) of such API would not have to be (entirely) made up of Powercord developers, Pull Requests exist for a reason. Sorry not sorry for the misnaming of MPRIS2, its not a big deal as the node module handles it, I'll change what its called on the core issue.

MulverineX commented 3 years ago

And there's RPC covered ^^^. It's better that it's in that issue since such a feature should be made for all platforms, not just Linux, same goes for the controller.