search

powercord-org / powercord

A lightweight @discord client mod focused on simplicity and performance.
MIT License
1.2k stars 147 forks source link

Add commands for plugging stable, PTB, and development #633

Closed asportnoy closed 2 years ago

asportnoy commented 2 years ago

This adds commands for installing to Stable or PTB. This can be done by appending a version to the command: npm run <plug|unplug> [stable|ptb|canary|dev|development]. A warning will be given to the user and they will have to confirm before the install continues.

Screenshot on 2022-04-24 at 22 13 23

I was only able to test injection on macOS. I was able to find the windows paths here but I had to guess the Linux paths based on context.

I updated the info in the README, but the wiki still needs to be updated. You might want to move the README info to the wiki instead of where it currently is, but that is up to you. The information in the Discord server probably needs to be updated as well.

Closes #632 Also closes #647

Captain8771 commented 2 years ago

is there any reason discordDevelopment isnt included?

asportnoy commented 2 years ago

is there any reason discordDevelopment isnt included?

As far as I know, there's no advantage discordDevelooment has and it's not supposed to be used anyways

kekkodance commented 2 years ago

is there any reason discordDevelopment isnt included?

As far as I know, there's no advantage discordDevelooment has and it's not supposed to be used anyways

it's not about "advantages". if a user chose that they needed powercord on dev (which would be basically the same as a canary instance) they would have to do the rudimentary method of changing a string in powercord's injector, which makes your PR useless. it's not hard to add a new "dev" instance in the choices.

asportnoy commented 2 years ago

Alright. Let me know the install paths and the subdomain and I'll add it later today.

kekkodance commented 2 years ago

the pathname for dev is just "DiscordDevelopment"

asportnoy commented 2 years ago

And is it dev.discord.com? or development.discord.com?

kekkodance commented 2 years ago

discord dev just points to canary, doesn't it? they offer the installer for dev here: https://discordapp.com/api/download/development?platform=win but they do not have another endpoint like ptb.discord.com / canary.discord.com etc.

CanadaHonk commented 2 years ago

discord dev just points to canary, doesn't it

Just to confirm, yes it just loads the normal canary webapp_endpoint (https://canary.discord.com/app).

asportnoy commented 2 years ago

As with the other clients, I had to guess on the linux paths. But macOS and Windows should both be good.

asportnoy commented 2 years ago

Rebased