search

powercord-org / powercord

A lightweight @discord client mod focused on simplicity and performance.
MIT License
1.21k stars 147 forks source link

[Spotify] Broken when streamer mode enabled #64

Closed cyyynthia closed 5 years ago

cyyynthia commented 5 years ago

Due to the fact that discriminator is missing in the user account info, so we can't get the style of it TypeError: Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'.

davidcralph commented 5 years ago

on latest commit it seems to work fine for me :thinking:

cyyynthia commented 5 years ago

Try reloading while streamer mode is enabled. Since an element is missing it fails and throws an error

On Tue, Feb 5, 2019, 11:41 David Ralph <notifications@github.com wrote:

on latest commit it seems to work fine for me 🤔

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/powercord-org/powercord/issues/64#issuecomment-460590531, or mute the thread https://github.com/notifications/unsubscribe-auth/AJiSzxublUL0T-RWRx4TAHFx_7LxmNT2ks5vKV--gaJpZM4Z72pW .

davidcralph commented 5 years ago

oh, i see

cyyynthia commented 5 years ago

Updates on the issue: We do have kinda fixed it by using static value instead of fetching it dynamically. We do need a better fix and use dynamic values back, to ensure it'll work with custom themes or if Discord changes some CSS

cyyynthia commented 5 years ago

Fixed in #220