search

powercord-org / powercord

A lightweight @discord client mod focused on simplicity and performance.
MIT License
1.2k stars 147 forks source link

Folder Structure #656

Open moritztim opened 2 years ago

moritztim commented 2 years ago

Describe the bug The folder structure seems unnecessarily complicated, Powercord/src/powercord/plugins is where the plugins are at for example, while the injectors are not even in the src dir

To Reproduce

  1. look at the repo

Expected behavior

  1. you get confused

Desktop (please complete the following information):

Additional context

colin273 commented 2 years ago

This doesn't qualify as a bug. While it is a counterintuitive (or rather, questionable) design choice imo, it's not going to be changed anytime soon unless someone submits a PR to change the entire folder structure and the devs decide to accept it, considering that some plugins would break with a different folder structure.

As for the injectors, those are external scripts, while src/ is for the mod itself, the stuff that is loaded with Discord.

moritztim commented 2 years ago

As for the injectors, those are external scripts, while src/ is for the mod itself, the stuff that is loaded with Discord.

they are still scripts tho, so they still have no right to be in root, one would probably have to have another subdir inside src for powercord in that case, which would technically make more sense but might be even more complicated for the user...

asportnoy commented 2 years ago

If it really bothers you, you can just create an alias/shortcut/symlink/whatever your OS equivalent is to the plugins directory and put it wherever you want.

moritztim commented 2 years ago

ofc, I am not personally bothered by it, just thought it would be nicer to have it a bit clearer.

moritztim commented 2 years ago

As for the injectors, those are external scripts, while src/ is for the mod itself, the stuff that is loaded with Discord.

they are still scripts tho, so they still have no right to be in root, one would probably have to have another subdir inside src for powercord in that case, which would technically make more sense but might be even more complicated for the user...

👎 - @FifiTheBulldog

My point is that this should be in the src dir cause it doesn't belong with things like the readme imo, tho that might further complicate it, so it's fine

ToxicSmurf commented 2 years ago

grass