Right click on user crashes Discord

powercord-org / powercord

A lightweight @discord client mod focused on simplicity and performance.

MIT License

1.2k stars 147 forks source link

Right click on user crashes Discord #663

Closed asportnoy closed 2 years ago

asportnoy commented 2 years ago

Describe the bug Title

To Reproduce Title

Expected behavior Not crash

Desktop (please complete the following information):

OS: macOS
Powercord version: 794f8c6

Additional context

[x] I checked if Discord and/or Powercord are up to date
[x] I made sure this is not related to an external plugin or a theme

~~Only occurs on Canary right now~~ Changes landed on stable too. Other people were able to reproduce.

Lordmau5 commented 2 years ago

Did some debug logging and traced it down to this particular wrapInHooks call: https://github.com/powercord-org/powercord/blob/v2/src/fake_node_modules/powercord/util/injectContextMenu.js#L65

Not sure if that's helpful or you guys already know about it happening in this part of hte code, but since I'm also experiencing this I thought I'd look around a bit.

pythonius21 commented 2 years ago

happens to me too

Cosmiiko commented 2 years ago

Can reproduce. Version info:

Canary 135383 (52cc282) 
Host 1.0.47 Windows 10 64-Bit (10.0.19044)
Powercord v2 (794f8c6)

Edit: Issue seemingly went away it seems...

pythonius21 commented 2 years ago

Edit: Issue seemingly went away it seems...

after you updated discord? Edit: Still crashes Canary 135468 (34b0605) Host 1.0.47 Windows 10 64-Bit (10.0.19044) Powercord v2 (794f8c6)

asportnoy commented 2 years ago

The issue comes and goes.