powerhouse-inc / connect

https://document-model-electron.vercel.app
4 stars 3 forks source link

Detect version differences and prompt page refresh #341

Closed CallmeT-ty closed 2 months ago

CallmeT-ty commented 4 months ago

This will deal with all cases were people have different version of connect, unknowning they need to refresh.

DoD

froid1911 commented 3 months ago
CallmeT-ty commented 3 months ago

Now up to the front end team to load the versioning in connect & show a toast when connect & switchboard are out of sync. Best way to do it through shared pair programming.

wkampmann commented 3 months ago

I saw this notification pop up now in the dev environment. We should do 2 more things to make this work:

On a more general note, testability should be part of our definition of done by default. For some features it may well be more work to make the feature testable than to do the actual implementation.

CallmeT-ty commented 3 months ago

Given todays issues, we'll have to see if the frequency sholuldn't be controled. Likely making it persistent will be enough.

wkampmann commented 3 months ago

Observing it more, I think the trigger condition needs to be improved too.

https://github.com/powerhouse-inc/connect/assets/1241878/212ed818-9024-468e-b8eb-0c437f013a5f

From this recording it's clear that the toaster is triggered by an unrelated error.

CallmeT-ty commented 3 months ago

When we deploy switchboard & connect. Both usually get deployed with same doc mod libs & doc drive. But they have different versions on their own. We can define a minimum version, not the exact version.

DOD

How do we test it?