search

powerhouse-inc / connect

https://document-model-electron.vercel.app
3 stars 2 forks source link

feat: fix load file from url #379

Closed ryanwolhuter closed 1 month ago

ryanwolhuter commented 1 month ago

the existing logic for opening files from the url made the assumption that files with no parent folder, i.e. ones directly in the drive, would always have null for the parentFolder property. However, there is logic in the document drive code that sets this value to "" instead. This causes the url logic to break.

To fix this for now, I have updated the url logic to treat falsy values for parentFolder as meaning the parent is the drive. However, in my opinion it would be better to refactor the code to always use null only, since that is more predictable.

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 1.0.0-dev.10 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 1.0.0-next.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: