powerhouse-inc / document-drive

GNU Affero General Public License v3.0
1 stars 0 forks source link

feat: enabled clientStrandsError event #229

Closed gpuente closed 2 months ago

gpuente commented 2 months ago

Description:

gpuente commented 2 months ago

We could emit a general "error" event. The initial parameter would be the error code or type

I wanted to be more specific with this error, so the trigger is included into the event, otherwise we would need to look at the error, validate that is a ClientError for the strands query, and then try to get the listener id from the query.

acaldas commented 2 months ago

We could emit a general "error" event. The initial parameter would be the error code or type

I wanted to be more specific with this error, so the trigger is included into the event, otherwise we would need to look at the error, validate that is a ClientError for the strands query, and then try to get the listener id from the query.

The idea would be for the error event to have custom arguments for each error. Like in https://github.com/powerhouse-inc/document-drive/blob/main/src/server/error.ts.

But we can do that later when we add a new error.