Closed KirillDogadin-std closed 1 year ago
@valiafetisov
not sure what the requirement remove initial static md files
means in the issue. Could you elaborate what here is wrong if it is?
Docs are gitignored now and are generated automatically after install , after update, before dev
, before start
. That should cover the most cases of the tool used.
Seems ready for review
pls try :
node_modules/
in both frontend
and core
directories.npm i
in both of the directories.aaalright. I am failing to reproduce:
docker-compose up --build --force-recreate
And the documentation is displayed.
Please:
Thanks for figuring it out! I guess the recent changes you've introduced are related to this inconsistent docker behaviour with the implemented solution.
The problem is, docker-compose
no longer started for me due to no space left on device
(see logs below) caused by huge context size (from frontend/node_modules
) that it trieed to copy into the image. So it seems like docker-compose
started to ignore frontend/.dockerignore
for me and instead used new .dockerignore
which said nothing about frontend/node_modules
After adding more lines from frontend/.dockerignore
to the root .dockerignore
file, I got correct logs and the image is being properly built:
=> [switchboard_api internal] load build context 0.2s
=> => transferring context: 2.15MB 0.2s
=> [switchboard_frontend internal] load build context 0.2s
=> => transferring context: 4.88MB 0.2s
=> [switchboard_db_migrations internal] load build context 0.2s
=> => transferring context: 2.15MB
This is anyway irrelevant for the CI as it builds images in a fresh context every time. But let's see how it will be in practice 🙂
close #57