powerman / dockerize

Utility to simplify running applications in docker containers
MIT License
185 stars 17 forks source link

Honoring PROXY settings #252

Closed iaean closed 1 year ago

iaean commented 1 year ago

Is it possible to let the http.Client honor HTTP_PROXY, HTTPS_PROXY and NO_PROXY from environment?

E.g. here https://github.com/powerman/dockerize/blob/c9d55019deed3e91858951e23c14a002be8439de/wait.go#L128

AFAIK its just add Proxy: http.ProxyFromEnvironment to the transport config. But I'm not really familiar with Go.

Thx for your investigation.

powerman commented 1 year ago

Sounds like a good idea!

powerman commented 1 year ago

Released in 0.17.0.