search

powerman / perl-Crypt-MatrixSSL3

Perl module: Crypt::MatrixSSL3 - Perl extension for SSL and TLS using MatrixSSL.org
https://metacpan.org/release/Crypt-MatrixSSL3
Other
1 stars 1 forks source link

Change API: croak in $ssl->get_outdata() #8

Closed powerman closed 8 years ago

powerman commented 8 years ago

Just like proposed for matrixSslGetReadbuf() in https://github.com/powerman/perl-Crypt-MatrixSSL3/issues/7#issuecomment-188184908 matrixSslGetOutdata() should never return any errors interesting to user, so croak() in case of error will simplify API without any harm.

powerman commented 8 years ago

@vonydev I'm taking your comment at #8

matrixSslGetReadbuf() returns <0 (PS_ARG_FAIL) in one case: $ssl or $in are NULL which will never happen and it's safe to ignore.

as valid for matrixSslGetOutdata() too and going to make both API changes. Let me know if you think that's wrong.