search

powerpak / hn-sidebar

Hacker News Sidebar for Chrome
https://chrome.google.com/webstore/detail/hacker-news-sidebar/ngljhffenbmdjobakjplnlbfkeabbpma
MIT License
22 stars 5 forks source link

Load sidebar only on demand #4

Open niutech opened 9 years ago

niutech commented 9 years ago

Privacy is key, so sending all the visited URLs to any third-party is inacceptable. Why not showing the sidebar only after clicking the button, so that only the page I want will be searched for comments?

powerpak commented 9 years ago

Good idea; i should note that the current design is that the button only shows if there is an HN thread about it. That's a nice datapoint, because it often shows for pages that I wouldn't expect to have found a thread for, and then you can scan the comments. And when it doesn't, I know there probably isn't such a thread.

If it shows up on all pages regardless of whether there is a thread, that might be distracting, because you'll wind up clicking on it all the time just to check whether there is a thread.

huyz commented 9 years ago

+1 I'd rather preserve my privacy and search for a HN thread only when I'm interested in comments, in the same way I sometimes make the conscious decision to jump to the bottom of an article looking for in-page comments.

huyz commented 9 years ago

I wouldn't always show a floating HTML button on every page. I would have an extension icon in the Chrome toolbar which I would click as needed.

huyz commented 9 years ago

I modified the extension to enable on-demand search for HN: https://github.com/huyz/hn-sidebar

I didn't create a pull request because it should be a user option to have one behavior or the other and I didn't implement that toggle.