powerpak / hn-sidebar

Hacker News Sidebar for Chrome
https://chrome.google.com/webstore/detail/hacker-news-sidebar/ngljhffenbmdjobakjplnlbfkeabbpma
MIT License
22 stars 5 forks source link

Bloom filters #7

Open simonacca opened 8 years ago

simonacca commented 8 years ago

I just discovered this plugin and I very much like it! Although I am not really keen on sending all the URLs I visit to algolia or other services.

How are you on the idea of using a bloom filter with all hn stories urls, so that the pages the user visits are tested locally for presence in HN, and algolia is contacted only when the test is positive?

huyz commented 8 years ago

I was under the impression that URLs were only sent when you pressed the browser icon.

simonacca commented 8 years ago

How can that be, given that the sidebar toggle button is displayed only when the page visited is on HN?

huyz commented 8 years ago

Oh that's right, I forgot that I had forked this repo and modified it exactly because I had the same fears as you. I added a browser bar icon and I only search on demand. See https://github.com/huyz/hn-sidebar