search

powerpaul17 / maxcul

Home assistant integration to use Max devices over a CUL
3 stars 2 forks source link

Add battery_low as extra_state_attribute #3

Closed h2horn closed 1 year ago

h2horn commented 1 year ago

Pass the batter_low attribute from pymaxcul to homeassistant.

powerpaul17 commented 1 year ago

Hello and thanks for the PR. There should already be a binary sensor for the battery status in binary_sensor.py. Is an attribute of more use to you (just out of curiosity)?

h2horn commented 1 year ago

Oh, I didn't see that. I thought it was related to the window sensors, and I'm sure the binary sensors weren't there yesterday, but now I see them ... So we can close this?

powerpaul17 commented 1 year ago

It may have some hiccups sometimes, it works well enough for daily use for me with the occasional restart (HA has lots of updates so restarts are rather frequently if you update.. :wink: ). Maybe it is also related to instable connection to the Cube or so. As I said, it's nice to see that other people have use for this integration too but I cannot guarantee stability or so. That's also the reason that I haven't published it on HACS... but PRs are of course always welcome.. :slightly_smiling_face: