powerscorinne / GLRM

MIT License
97 stars 49 forks source link

Example doesnt work #7

Open lzdh opened 6 years ago

lzdh commented 6 years ago

Hi, 'GLRM' runs really slow on my data, so I am trying the example, and found out: 1. the definition of missing1 is beyond the index bond. I corrected it and then it gives me the following error. Am I doing anything wrong? screen shot 2018-02-08 at 19 13 35

vsoch commented 6 years ago

You are using a different version than the example intended, this looks like a bug that was fixed: https://github.com/pytorch/pytorch/issues/2315 The solution is for the example to provide a container or requirements file to install the correct one, otherwise you have to just figure it out this way :)

lzdh commented 6 years ago

I see! Thank you very much for the reply :)

gokceneraslan commented 6 years ago

You are using a different version than the example intended, this looks like a bug that was fixed: pytorch/pytorch#2315 The solution is for the example to provide a container or requirements file to install the correct one, otherwise you have to just figure it out this way :)

Sorry @vsoch how is this related to pytorch? Just out of curiosity.

vsoch commented 6 years ago

Take a look at the error - Variable object has no attribute shape. It's the same issue with the version of the supporting library being used is the wrong one.

gokceneraslan commented 6 years ago

OK, yes I saw that but I just cannot see where the pytorch variable is defined. Neither in the example, nor in the GLMR code, I see any pytorch code. This is why I asked.

vsoch commented 6 years ago

Sorry to not be clear - it's not relevant to pytorch, but I was pointing out that they both have some same underlying module that is producing the same error, likely whatever is used for the Variable in both...