powertab / powertabeditor

View and edit guitar tablature.
https://powertab.github.io
GNU General Public License v3.0
526 stars 68 forks source link

MIDI Player doesn't turn off Let Ring when stopped in middle of measure. #337

Closed BigHonkinDaddy closed 2 years ago

BigHonkinDaddy commented 2 years ago

Description When MIDI Player is stopped on a note that is allowed to "let ring", then when the MIDI is restarted from the top of the score, the notes will ring (even though those notes are not supposed to ring). This happens when the MIDI player is stopped on notes that ring in the middle of the measure. If stopped on a note at the end of the measure, behavior is correct as expected. See attached image for detail. Bug Example - Let Ring.zip

To Reproduce

  1. Write a score (or use the attached sample .zip) with notes in the middle of the score (and in the middle of a measure) that are allowed to "Let Ring".
  2. Play the MIDI Player from the top.
  3. When the MIDI Player gets to the note(s) that ring, stop the MIDI player.
  4. Restart the MIDI Player from the top.
  5. Notice the notes at the top will ring out, erroneously.

Additional Info If applicable, add a screenshot or attach an example file that demonstrates the issue. PTE Bug - Let Ring

Version Alpha 15 Windows x86