search

powertab / powertabeditor

View and edit guitar tablature.
https://powertab.github.io
GNU General Public License v3.0
526 stars 68 forks source link

build: explicitly include std::optional in midiplayer.h #341

Closed psyomn closed 2 years ago

psyomn commented 2 years ago

Description of Change(s)

When trying to build this project on my machine, I got a compilation error, complaining that the 'optional' type was not recognized. I had to explicitly include it in order to compile successfully.

Compilation was attempted with: gcc (GCC) 11.1.0

Fixes Issue(s)

psyomn commented 2 years ago

Not quite sure what's up with the mac build. I'll take a look tomorrow!

cameronwhite commented 2 years ago

I'll have to look into the Mac build - it's not anything related to your change! The installer is now signed and notarized which requires some certificates / passwords that are registered as secrets in the main repo. Seems like they aren't accessible in PR builds (probably a good thing for security) so I'll need to adjust the build script a bit

cameronwhite commented 2 years ago

Is your fork fully up to date? I think 91506a36 fixed the same issue

cameronwhite commented 2 years ago

a00d7a7aa416ea4569f4819d59920dd7b4b1cc8c should hopefully fix the Mac issue!

I think this can be closed as it's already fixed now, thanks!