powertab / powertabeditor

View and edit guitar tablature.
https://powertab.github.io
GNU General Public License v3.0
526 stars 68 forks source link

MIDI Player improvements - scrolling score even at end #360

Open BigHonkinDaddy opened 2 years ago

BigHonkinDaddy commented 2 years ago

During MIDI play, the score jump-scrolls to keep the active "system" at the top of the screen. This is useful behavior for video screen capture for when I put together a split screen video of the performance and the scrolling notes/and tabs screen-captured from PowerTab MIDI player. EXCEPT when it gets to the end of the score, it stops scrolling score and instead moves the red MIDI player line down the page out of view of my screen capture. Can this behavior be made optional so that even the last systems of the score are scrolled to the top of the page?

cameronwhite commented 2 years ago

I'd say that what you're describing should be the default, and is probably what the code intended to be doing.

This is happening in ScoreArea::adjustScroll() which tries to set the scroll to the top of the system. It probably fails at the bottom of the score because the scrollbar can't go any farther, so likely the code needs to do something a bit different or ensure there is some extra space at the bottom of the rendered score..