Open Fieora opened 2 years ago
I need to read up on shamisens :) , but at first glance this might make sense as a property of the tuning Is each fret is still a half step?
I need to read up on shamisens :) , but at first glance this might make sense as a property of the tuning Is each fret is still a half step?
Yes, they are still half steps.
Thanks! Yeah I'd say this makes sense to have as part of the tuning, maybe as an enum
describing the different fret labeling methods.
Then SystemRenderer::drawTabNotes()
could take this into account, and to find the tuning for the note being drawn the logic would be similar to https://github.com/powertab/powertabeditor/blob/master/source/painters/stdnotationnote.cpp#L140
Description Allow custom fret labels (attached to instrument, player, or tuning) to allow other instruments that don't just use numbered frets/positions.
For example, shamisen players have the following: 0 -> 0 1 -> 1 2 -> 2 3 -> 3 4 -> # 5 -> 4 6 -> 5 7 -> 6 8 -> 7 9 -> 8 10 -> 9 11 -> 1b 12 -> 10 13 -> 11 14 -> 12 15 -> 13 16 -> 1# 17 -> 14 18 -> 15 19 -> 16 20 -> 17 21 -> 18
Additional context Shamisen players would LOVE this feature, and essentially there is no tab editor that works easily for us, so this would be a killer feature.