search

powertab / powertabeditor

View and edit guitar tablature.
https://powertab.github.io
GNU General Public License v3.0
519 stars 68 forks source link

Pitch shifted unexpectly when start to play from the middle of the score #395

Closed NalihznehC closed 1 year ago

NalihznehC commented 1 year ago

Description I added many slides inside my tab, maybe those slides went wrong while start playing from the midst of tab.

To Reproduce 花降らしMidiExp202209290002.zip image Open the .pt2 file and navigate to the 18th bar and press spacebar to play, the violin (vocal) will be out of tune (sometimes lead guitar will also be weirdly shifted)

Additional Info I cannot find its bug pattern as listening to the bug is a torture to my ears. The report also looks less elegant, sorry for that. 花降らし(Part1).zip This is what it should sound like (exported perfectly and buglessly from Power Tab Editor (alpha18-51-gf11404c3)).

Version Windows 10 21H2 Power Tab Editor 2.0 Beta (v2.0.0-alpha18-51-gf11404c3)

NalihznehC commented 1 year ago

https://user-images.githubusercontent.com/39670573/192965471-303bd617-0c2a-4e34-bf2f-d3ed72e43562.mp4

Here is the torture.

wwhhff commented 1 year ago

I encountered the same issue which @NalihznehC has mentioned. The note sounds randomly out of tune when starting the playback in the middle of a song.

cameronwhite commented 1 year ago

I haven't been able to reproduce this yet (on macOS), but thank you for all the details! It does sound like an issue with the midi pitch wheel not being reset, or something similar

BigHonkinDaddy commented 1 year ago

Yes, this is definitely an issue that I've seen often. Its not random. if you start the midi player AFTER a slide, the pitch will be offset by the same amount as the prior slide... if the slide was up 4 half steps, the pitch of the notes (if you start the midi player after that slide) will be sharp by 4 half steps. I will attach a short sample powertab score as an example that might help reproduce the issue. Bug Example - Slide.zip

cameronwhite commented 1 year ago

Thanks for the file - I still couldn't reproduce it on macOS, but I do get the issue on Windows so I'll look into it further there

cameronwhite commented 1 year ago

I think I've got a fix for this, but more testing would be appreciated! The latest build can be downloaded from https://github.com/powertab/powertabeditor/actions/runs/3260359815 once it's finished building

BigHonkinDaddy commented 1 year ago

Your fix seems to be working. I tried it out on several of my tabs and its working great. Windows 10 x64.