powertab / powertabeditor

View and edit guitar tablature.
https://powertab.github.io
GNU General Public License v3.0
518 stars 68 forks source link

Windows local build scripts #468

Closed Dj-Viking closed 4 months ago

Dj-Viking commented 4 months ago

Description of Change(s)

Adds powershell scripts to hopefully make installing the dependencies and building the cmake project much easier for windows users. Followed much of how the github action itself is building the x64 windows build.

Fixes Issue(s)

cameronwhite commented 4 months ago

This is great, thanks for working on this! My only suggestions would be:

Dj-Viking commented 4 months ago

Sure thing! The convention that I found for PowerShell script files and function names is Pascal-Snake cased with the verb the first part of the snake case. As most PowerShell cmdlets follow this convention.

I had renamed the file but I think Git was acting weird not recognizing file renames....I sometimes forget about that part of Git doesn't always track file name casing changes

And, fun fact, when PowerShell is interpreting in the REPL when invoking a file or function the casing doesn't matter 😆 and it's very lenient in how you can call the files. And most of PowerShell is not case sensitive for whatever reason.

.\scripts\Run-CMakeBuild.ps1;

.\scripts\run-cmakebuild; # add .ps1 if you want to 

.\scripts\RuN-CmAKeBuilD;

are all valid LOL

cameronwhite commented 4 months ago

Looks good, thanks!