Build problem on Fedora 40

powertab / powertabeditor

View and edit guitar tablature.

https://powertab.github.io

GNU General Public License v3.0

518 stars 68 forks source link

Build problem on Fedora 40 #478

Closed ycollet closed 4 weeks ago

ycollet commented 1 month ago

I am compiling the current git repository of powertab on Fedora 40 with gcc 14.1.1. minizip-ng-compat-devel 3.0.10 is installed. I needed to fix source/formats/gp7/gp7exporter.cpp to allow powertab to compile:

adding '#include '
renaming zipOpenNewFileInZip64 to zipOpenNewFileInZip_64 After that powertab compiled fine.

cameronwhite commented 1 month ago

I think this may be a bug in minizip-ng?

In the original zlib version there is zipOpenNewFileInZip64() (https://github.com/madler/zlib/blob/develop/contrib/minizip/zip.h#L163), but in minizip-ng-compat it has the _64 suffix instead (https://github.com/zlib-ng/minizip-ng/blob/develop/mz_compat.h#L177)

I'm guessing it might have been a copy-paste error since the other variants like zipOpenNewFileInZip2_64 do actually have the underscore in the original minizip

cameronwhite commented 1 month ago

Could you try the latest commit f6662dd and see if that works in your environment?

ycollet commented 4 weeks ago

Just check and it worked. Thanks a lot ! I close the ticket.