search

powervr-graphics / Native_SDK

C++ cross-platform 3D graphics SDK. Includes demos & helper code (resource loading etc.) to speed up development of Vulkan, OpenGL ES 2.0 & 3.x applications
https://docs.imgtec.com/sdk-documentation/html/introduction.html
MIT License
702 stars 197 forks source link

Support for VK_MVK_macos_surface #44

Closed sugoi1 closed 5 years ago

sugoi1 commented 5 years ago

I added support for VK_MVK_macos_surface in all PowerVR Vulkan samples and tested the applications using SwiftShader's Vulkan implementation on MacOS.

Note: SwiftShader runs on many platforms (Windows, Linux, MacOS, Android, ARM, and more) and PowerVR could even benefit from using it to verify the conformance of test applications.

sugoi1 commented 5 years ago

I see the libSPVRemapper related failures. I need a way to remove the SPVRemapper dependency on MacOS...

omarzohdi commented 5 years ago

Hi @sugoi1, I've looked at your pull request and it looks great. Thanks for the contribution. There's a few tweaks we want to apply before we push it to master. I've edited your pull request to merge into a feature branch. I'll push it to master once I've sorted everything out.

Omar.

sugoi1 commented 5 years ago

Thanks Omar. Don't hesitate to ask questions if anything in my change is unclear. I hope I made most things fairly straightforward.

omarzohdi commented 4 years ago

Hi @sugoi1, apologies for the late update. Just wanted to let you know we have added support for MVK on MacOS in our latest release R19.2-v5.4. It was more time consuming than expected but it all worked out. So I'll be deleting the feature branch as it's redundant now. Thanks again for the contribution.