Fix running VulkanGlass with the Vulkan Validation Layers

powervr-graphics / Native_SDK

C++ cross-platform 3D graphics SDK. Includes demos & helper code (resource loading etc.) to speed up development of Vulkan, OpenGL ES 2.0 & 3.x applications

https://docs.imgtec.com/sdk-documentation/html/introduction.html

MIT License

702 stars 197 forks source link

Fix running VulkanGlass with the Vulkan Validation Layers #61

Closed sugoi1 closed 4 years ago

sugoi1 commented 4 years ago

Running VulkanGlass with the Vulkan Validation Layers hits errors within: https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/master/layers/core_validation.cpp#L2211

Adding VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT on vkBeginCommandBuffer calls fixes this issue and shouldn't hurt any of the other samples.

sugoi1 commented 4 years ago

Friendly ping. Could anyone have a look or investigate this? Thanks.

omarzohdi commented 4 years ago

Hi @sugoi1, sorry for the late reply and thank you for the pull request. We, however, decided to go in a slightly different direction and we fixed the VulkanGlass example. The synchronization in that example was not correct to begin with so the latest commit should fix the validation layers issue you were seeing. I'll close this pull request for now but do let me know if any other issue persists.

Omar.

sugoi1 commented 4 years ago

Great, thanks for fixing this! I'll try testing it locally when I have some time.