search

powmedia / backbone.bootstrap-modal

Bootstrap Modal wrapper for use with Backbone.
MIT License
183 stars 97 forks source link

Bootstrap 3 like events #45

Closed wwebfor closed 10 years ago

wwebfor commented 11 years ago

Without this triggers (hidden.bs.modal) script will not remove content from DOM.

powmedia commented 11 years ago

Is this replacing your previous pull request?

Also can you explain why you've renamed the events? Thanks

wwebfor commented 11 years ago

Because in TW Bootstrap 3 events like shown, hiden has been renamed to shown.bs.modal and hidden.bs.modal.

http://getbootstrap.com/javascript/#modals

powmedia commented 10 years ago

I can't get the shown.bs.modal event to fire, is it working for you?

ihortymoshenko commented 10 years ago

@powmedia, it works for me, can you merge? :)

powmedia commented 10 years ago

The bootstrap3 branch is using these events (but still triggering the standard 'shown' and 'hidden' events on the Backbone.Modal object). If that's all working for you I'll merge that into master.

ihortymoshenko commented 10 years ago

@powmedia, ok, let's do it. It won't break Backbone.BootstrapModal API

powmedia commented 10 years ago

That's been merged in to master, closing