powsybl / powsybl-afs

AFS modules for powsybl
Mozilla Public License 2.0
3 stars 1 forks source link

Do not connect backward dependencies to listener when invalidate #146

Closed BrunoRte closed 4 months ago

BrunoRte commented 7 months ago

Please check if the PR fulfills these requirements

Does this PR already have an issue describing the problem? NO

What kind of change does this PR introduce? Feature

What is the current behavior? When object is invalidated, it's invalidate all this backward dependencies. To do this we create a new object in order to invalidate it. It is not necessary to "connect" it because this has to effect of subscribing it to event listener which is useless since its lifespan is only local to the function

What is the new behavior (if this is a feature change)? The created backward dependency is no longer connected upon invalidation

Does this PR introduce a breaking change or deprecate an API?

What changes might users need to make in their application due to this PR? (migration steps) The invalidate() method now return the list of all the backwardDependencies. All classes that override this method must update their signature as well as their behavior

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud